London | 25-SDC-July | Ali Qassab | Module-Legacy-Code | Sprint 1 | Hashtag link doesn't work correctly #44
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Fix Hashtag Parsing Issue
Problem: Hashtag links with spaces or punctuation were creating broken URLs and showing empty pages.
Example: Clicking
#SwizBiz
in "Let's get some #SwizBiz love!!" created URL/hashtag/SwizBiz love!!
which showed no blooms.Solution: Updated hashtag regex from
/\B#[^#]+/g
to/\B#\w+/g
to only capture valid hashtag characters (letters, numbers, underscores).Result: All
#SwizBiz
hashtags now correctly navigate to/hashtag/SwizBiz
and show all related blooms.Files Changed:
front-end/components/bloom.mjs
- Updated_formatHashtags()
function